From 6f18d015013d04e02349b44621e041d4d6faee40 Mon Sep 17 00:00:00 2001 From: Yuan Fu Date: Wed, 23 Jan 2019 14:39:51 -0500 Subject: [PATCH] Revert "Simplify childframe creation" Built-in function doesn't really reused the childframe, change back to manually reuse. This reverts commit 6ceeb22b68fda15a561d3ca6fd1eb36f6db75e5c. --- eldoc-box.el | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/eldoc-box.el b/eldoc-box.el index ebe64c0..04049ee 100644 --- a/eldoc-box.el +++ b/eldoc-box.el @@ -234,9 +234,10 @@ Checkout `lsp-ui-doc--make-frame', `lsp-ui-doc--move-frame'." `((default-minibuffer-frame . ,(selected-frame)) (minibuffer . ,(minibuffer-window)) (left-fringe . ,(frame-char-width))))) - (window (display-buffer-in-child-frame - buffer - `((child-frame-parameters . ,parameter)))) + (window (or (and eldoc-box--frame (frame-selected-window eldoc-box--frame)) + (display-buffer-in-child-frame + buffer + `((child-frame-parameters . ,parameter))))) (frame (window-frame window)) (main-frame (selected-frame))) (make-frame-visible frame)