jessieh/eldoc-frame
jessieh/eldoc-frame
1
Fork 0
Code Issues Pull Requests Releases Activity

Remove unnecessary check for empty string in eldoc-box--display

Browse Source 
* eldoc-box.el (eldoc-box--display): Now we require the caller to make
sure the string is not empty.
This commit is contained in:
Yuan Fu 2022-02-20 12:47:10 -08:00
parent 646ae5cdd8
commit 6fbb6e3e19
No known key found for this signature in database
GPG Key ID: 56E19BC57664A442
1 changed files with 16 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
eldoc-box.el
View File

@ -185,22 +185,22 @@ Intended for internal use."
;;;;; Function ;;;;; Function
(defun eldoc-box--display (str) (defun eldoc-box--display (str)
"Display STR in childframe." "Display STR in childframe.
(unless (equal str "") ; WORKAROUND lsp returns empty string from time to time STR has to be a proper documentation, not empty string, not nil, etc."
(let ((doc-buffer (get-buffer-create eldoc-box--buffer))) (let ((doc-buffer (get-buffer-create eldoc-box--buffer)))
(with-current-buffer doc-buffer (with-current-buffer doc-buffer
(setq mode-line-format nil) (setq mode-line-format nil)
(when (bound-and-true-p global-tab-line-mode) (when (bound-and-true-p global-tab-line-mode)
(setq tab-line-format nil)) (setq tab-line-format nil))
;; without this, clicking childframe will make doc buffer the current buffer ;; without this, clicking childframe will make doc buffer the current buffer
;; and `eldoc-box--maybe-cleanup' in `eldoc-box--cleanup-timer' will clear the childframe ;; and `eldoc-box--maybe-cleanup' in `eldoc-box--cleanup-timer' will clear the childframe
(buffer-face-set 'eldoc-box-body) (buffer-face-set 'eldoc-box-body)
(setq eldoc-box-hover-mode t) (setq eldoc-box-hover-mode t)
(erase-buffer) (erase-buffer)
(insert str) (insert str)
(goto-char (point-min)) (goto-char (point-min))
(run-hook-with-args 'eldoc-box-buffer-hook)) (run-hook-with-args 'eldoc-box-buffer-hook))
(eldoc-box--get-frame doc-buffer)))) (eldoc-box--get-frame doc-buffer)))
(defun eldoc-box--window-side () (defun eldoc-box--window-side ()