From d88e7a5ba1fd0e33dbe18e30866735fdea3ef239 Mon Sep 17 00:00:00 2001 From: Yuan Fu Date: Sat, 4 Mar 2023 22:42:36 -0800 Subject: [PATCH] Make credit more regular * README.org (Credit): * eldoc-box.el: --- README.org | 5 +++-- eldoc-box.el | 9 +++------ 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/README.org b/README.org index 364de19..c860ce4 100644 --- a/README.org +++ b/README.org @@ -47,5 +47,6 @@ As of writing this README, eglot doesn't have a public mode hook, use this hook: To keep eldoc from displaying documentation at point without enabling any minor mode above: =(add-to-list 'eglot-ignored-server-capabilites :hoverProvider)=. -* Contributors -- [[https://github.com/joaotavora][João Távora]] +* Credit +- Thanks to for [[https://github.com/joaotavora][João Távora]] for some valuable contribution and explain on eldoc and eglot internals. +- This package is initially adapted from Sebastien Chapuis’s package lsp-ui.el. diff --git a/eldoc-box.el b/eldoc-box.el index e6af00a..e22fde9 100644 --- a/eldoc-box.el +++ b/eldoc-box.el @@ -1,13 +1,10 @@ ;;; eldoc-box.el --- Display documentation in childframe -*- lexical-binding: t; -*- -;; Copyright (C) 2017-2018 Sebastien Chapuis, 2018 Yuan Fu +;; Copyright (C) 2018 Yuan Fu ;; Version: 1.10 -;; Author: Sebastien Chapuis -;; Maintainer: Yuan Fu -;; Contributors: -;; João Távora +;; Author: Yuan Fu ;; URL: https://github.com/casouri/eldoc-box ;; Package-Requires: ((emacs "27.1")) @@ -283,7 +280,7 @@ STR has to be a proper documentation, not empty string, not nil, etc." "Return the side of the selected window. Symbol ‘left’ if the selected window is on the left, ‘right’ if on the right. Return ‘left’ if there is only one window." - (let ((left-window(window-at 0 0))) + (let ((left-window (window-at 0 0))) (if (eq left-window (selected-window)) 'left 'right)))